On 02/28/2014 12:17 PM, Daniele E. Domenichelli wrote:
> Please review the topic FeatureSummary_combine_WHAT_values.
> 
> This patch allows to combine and reorder values for the "WHAT" option in
> FeatureSummary.

In principle the change looks good to me but I'm not familiar with this
module as a developer or user so I cannot comment in more detail.

Please add a Tests/RunCMake/FeatureSummary test to cover at least the
new error messages.

Thanks,
-Brad

-- 

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers

Reply via email to