On 03/10/2014 10:38 AM, Brad King wrote:
> Thanks. Now the docs look good too. Please rebase on master
> and merge to 'next' for testing.
Please add test cases for the FindPkgConfig interface and argument
parsing errors. The test can just fake the location of pkg-config
with a dummy if necessary.
Also the hunks:
+ if(UNIX)
+ string(REPLACE "\\:" ";" _path "${_path}")
+ endif()
should not be necessary because TO_CMAKE_PATH already does that.
It looks like TO_NATIVE_PATH does not do the reveres though so that
explicit replacement is still needed.
Thanks,
-Brad
--
Powered by www.kitware.com
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Kitware offers various services to support the CMake community. For more
information on each offering, please visit:
CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
