On 05/22/2014 02:58 PM, Taylor Holberton wrote:
> This patch adds windows and unix search paths that Freetype normally installs
> to.
Thanks for working on this. The patch appears to make style
and code layout changes at the same time as functional changes.
Please split that up into separate patches. Clean up style
first, then make functional changes.
The proposed paths:
+if (WIN32)
+ set (FREETYPE_PATHS ${FREETYPE_PATHS} $ENV{PROGRAMFILES}/freetype)
+ set (FREETYPE_PATHS ${FREETYPE_PATHS} $ENV{PROGRAMFILES}/freetype2)
+else()
+ set (FREETYPE_PATHS ${FREETYPE_PATHS} /usr)
+ set (FREETYPE_PATHS ${FREETYPE_PATHS} /usr/local)
+endif()
should not be necessary.
See CMAKE_SYSTEM_PREFIX_PATH settings on unix and windows:
http://cmake.org/gitweb?p=cmake.git;a=blob;f=Modules/Platform/UnixPaths.cmake;hb=v3.0.0-rc6#l32
http://cmake.org/gitweb?p=cmake.git;a=blob;f=Modules/Platform/WindowsPaths.cmake;hb=v3.0.0-rc6#l32
and how the find commands use it:
http://www.cmake.org/cmake/help/v3.0/command/find_library.html
http://www.cmake.org/cmake/help/v3.0/command/find_path.html
With proper PATH_SUFFIXES I do not think the above guesses
should be needed.
-Brad
--
Powered by www.kitware.com
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Kitware offers various services to support the CMake community. For more
information on each offering, please visit:
CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
