On 06/24/2014 03:09 PM, Ben Boeckel wrote:
> The proper way to read lines from a file using iostream is:
> 
>     std::string line;
>     while (std::getline(istr, line)) {
>         // use line
>     }

If that actually worked on all old stream libraries then we would
not need GetLineFromStream.  Also GetLineFromStream has a separate
output argument for indicating whether the line ended in a newline.

> Unfortunately, it looks like there's unavoidable extra logic in there.
> Maybe we could do:
> 
>     #ifdef BROKEN_STREAMS
>     // crutch code
>     #else
>     // sanity
>     #endif

Yes, please try this.

-Brad

-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Reply via email to