On 06/27/2014 04:13 PM, Adam Strzelecki wrote: > Previously all explicit dependencies inside build folder were considered as > possible build command side-effects and phony rules were produced for them in > case they don't exist yet starting build. This however incorrect since regular > compile inputs need to exist otherwise cmake will fail. Moreover the exception > for sources having GENERATED property that can be missing is already handled > by > WriteAssumedSourceDependencies.
Thanks! I've applied this series with minor tweaks to coding style and the commit messages: Ninja: Consider only custom commands deps as side-effects (#14972) http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=a33cf6d0 Ninja: Don't limit custom cmd side-effects to build folder (#14972) http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=7243c951 Ninja: Skip generating empty phony rules http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=93371ed5 -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
