>> cfbundles are currently not installed as directory, but the binary from
>> Contents/MacOS is directly installed to the destination.
>>
>> attached patch fixes the issue.
> 
> Thanks.
> 
> I do not understand this line:
> 
>> +      std::string targetNameBase = targetName.substr(0, 
>> targetName.find_first_of("/"));
> 
> Why do we need to look for the first slash?

targetName is:
${BundleName}${BundleExtension}/Contents/MacOS/${BundleName}

we basically want to find ${BundleName}. i did not find any way to
determine this information from the Target.

> Also, look earlier in that function for the blocks starting in:
> 
>       // Handle OSX Bundles.
>       if(this->Target->IsAppBundleOnApple())
> 
> and
> 
>     else if(this->Target->IsFrameworkOnApple())
> 
> Those cases do special handling for the post-installation tweaks.
> Is something similar needed here?

i wonder: which tweaks are they? i've seen the comments, but failed to
understand, what kind of post-install tweaks they add, as it is mainly
about changing source and destinations. in my use-case it seems to work,
but of course i might be missing something ...

cheers,
tim


-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Reply via email to