Hi Nils, and other developers! 15.07.2014, 01:21, "Nils Gladitz" <nilsglad...@gmail.com>: > Hello again :)
> Some stuff that remains from my earlier observations: > - A Lot of commented out code that should be removed. I do this work sometimes > Is Unescaped XML content from CMake variables. Now I use cmXMLSafe in several places > Some other random stuff I noticed: > - CPACK_IFW_BINARYCREATOR_EXECUTABLE_FOUND seems redundant given that > find_program() already encodes this in the cache variable. I think you're right and I'll get rid of this variable in the near future. But as long as the variable is still alive. > - In the CMake coding conventions class members start uppercase. The names of the methods I write with a capital letter, but the property names with a small letter as in the base class cmCpackGenerator. > I tried building a CMake installer with the generator again but it > failed with: > Caught exception: Component version for > '/home/ngladitz/src/git/cpackifwgenerator/build/_CPack_Packages/Linux-x86_64/IFW/cmake-3.0.20140709-gd078a-Linux-x86_64/packages/CMake/meta/package.xml' > is invalid! <Version>3.0.20140709-gd078a</Version> Now I fixed it. Should work. Regards -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
