Thanks. Actually I think adding "xz" is incorrect anyway. We
support compressed tarballs, not arbitrary compressed files.
Therefore the list should be
7z|bz2|tar\\.gz|tar\\.xz|tgz|txz|zip
correct?
Well, then it should be tar.bz2, too. And since this is a regex
anyway:
7z|tar\\.bz2|tar\\.[gx]z|t[xg]z|zip
Yes, correct.
I still like the original "list all the extensions separately and
explicitly" technique rather than "'simplifying' the regex" -- because
the first one is an "easier to parse as a human being" regex. Also,
it's "more greppable" if somebody is looking for .gz or .xz or tgz or
txz.
D
--
Powered by www.kitware.com
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Kitware offers various services to support the CMake community. For more
information on each offering, please visit:
CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers
