On Thu, Aug 21, 2014 at 2:21 PM, Brad King <brad.k...@kitware.com> wrote:
> On 08/21/2014 02:30 PM, Richard Shaw wrote: > > if (wxWidgets_CXX_FLAGS) > > + # Flags are expected to be a string here, not a list. > > + string(REPLACE ";" " " wxWidgets_CXX_FLAGS "${wxWidgets_CXX_FLAGS}") > > set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${wxWidgets_CXX_FLAGS}") > > Thanks. However, we shouldn't leak our local modification to the value > of wxWidgets_CXX_FLAGS, so the substitution should be done with the > result stored in a temporary local variable. > > Also, please start the commit message in "UsewxWidgets: ...". > > Ok, all updates have been incorporated, so I'm looking for an ACK to know if it appears ready to push into "next". http://cmake.org/gitweb?p=stage/cmake.git;a=commitdiff;h=e6fa6e60f6330ddf60294a0d9a6ed4cb3f27d4c4 Thanks, Richard
-- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers