On 10/27/2014 10:41 AM, Rolf Eike Beer wrote:
>> if("${_RPM_SPEC_HEADER}" MATCHES "REQUIRES_PRE" OR
>> "${_RPM_SPEC_HEADER}" MATCHES "REQUIRES_POST")
>
> This should really be using STREQUAL and not using dereferences on the
> left hand side.
Thanks. Actually I mentioned that in my first review in this thread
but forgot to check that it had been resolved in updated patches.
It doesn't matter though because the second commit replaces that
line with different logic anyway.
-Brad
--
Powered by www.kitware.com
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Kitware offers various services to support the CMake community. For more
information on each offering, please visit:
CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers
