On 10/28/2014 03:20 PM, Daniele E. Domenichelli wrote:
> Done, thanks.

Good.

In the updated docs for CMAKE_ARGS, CMAKE_CACHE_ARGS, and
CMAKE_CACHE_DEFAULT_ARGS, the intro line now needs a period.

The new RunCMake.ExternalProject test looks good.  However, it
does not verify that the external project actually builds with
the new options.  Please extend one of the main ExternalProject
tests to cover this too.

Thanks,
-Brad
-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Reply via email to