On 11/05/2014 12:14 PM, Tim Gallagher wrote: > I have attached an updated patch
Thanks! Please split this into two patches. The first one should do the refactoring of the variable name and corresponding logic with no functionality changes. The second one can add the Fortran feature. Also please keep C++ source lines to 79 columns or below. The FortranOnly test fails for me with: f95: error: gfortran does not support -E without -cpp because it doesn't enable preprocessing for lower-case extensions. You'll need to add another .F test source with an upper-case extension to activate preprocessing without special flags. Thanks, -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
