On 11/09/2014 12:05 PM, Daniele E. Domenichelli wrote:
> Fix regression in link order introduced by the link-line-dedup topic

Thanks.  I revised the implementation slightly to avoid prepending
to a vector on every iteration.  I've merged to 'next' for testing:

 Fix link line order when shared libraries are de-duplicated
 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=3c3589e1

 Test linking to a shared lib needed only through a static lib
 http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=a4716b6b

The change and its explanation make sense.  Please verify that
it still fixes your original case after my modification.

However, the test does not fail for me even without the fix.  I
think for 3.1.0-rc2 I will take this fix but not the test yet.
Please extend the topic to revise the test:

- See if it can be integrated into the Tests/Dependency test,
  perhaps as a new Case5 directory.

- Convert the test implementation to use only C so that the
  test can be switched to "project (Dependency C)" as it should
  have been already.

Thanks,
-Brad

-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Reply via email to