On 11/18/2014 6:16 AM, Ådne Hovda wrote: > X/Open Curses does not specify the getmax[xy]() functions/macros, only > getmaxyx()
Yes, it makes sense to use well-defined APIs. Thanks for explaining. > I've pushed my changes to > https://github.com/aadnehovda/CMake/tree/curses-hpux-fix and can create > a pull request if you think this is okay. No PR is needed. I've fetched from there. Please read CONTRIBUTING.rst, though we can finish this one with your branch on Github. This hunk: > -#else > -/* figure out which curses.h to include */ > -# if defined(CURSES_HAVE_NCURSES_H) > -# include <ncurses.h> > -# elif defined(CURSES_HAVE_NCURSES_NCURSES_H) > -# include <ncurses/ncurses.h> > -# elif defined(CURSES_HAVE_NCURSES_CURSES_H) > -# include <ncurses/curses.h> > -# else > -# include <curses.h> > -# endif removes a bunch of logic when __hpux is not defined. I think that is still needed on all platforms to include the proper curses headers. That should be able to subsume the hpux case now. Please revise or explain. Thanks, -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
