On 12/01/2014 03:26 PM, Stephen Kelly wrote:
> Existing uses of strtol also check errno. I guess your implementation should 
> too. 

Yes, IIUC it is a range check on whether the value can be represented.

> Then the existing users should use this new method.

In that case the type should be changed to 'long' instead of 'int',
and the current call site should be updated accordingly.

Thanks,
-Brad

-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Reply via email to