Hi CMake developers, yesterday I created a pull request with the attached patch. It was rejected because it was not clear, whether we should really require all these LaTeX related binaries. FindLATEX tries to find, and I wanted to make them all required, these binaries: LATEX_COMPILER PDFLATEX_COMPILER BIBTEX_COMPILER MAKEINDEX_COMPILER DVIPS_CONVERTER PS2PDF_CONVERTER LATEX2HTML_CONVERTER
I am unsure whether Brad is right or not. For users it would be great to simply have all these binaries. I cannot imagine someone is installing LaTeX without BibTeX or makeindex, as it does not make sense. The minimal set I would test would be LATEX_COMPILER PDFLATEX_COMPILER BIBTEX_COMPILER MAKEINDEX_COMPILER If this is still to restrictive, I propose to only test for the LaTeX compiler and let the user check for the other binaries (with if(MAKEINDEX_COMPILER) ) In any case, I'll have to clarify this in the documentation for my next patch. Bye Christoph
From 2ee99c5cd9d5bb508a6bd9931f05056c520ef5c2 Mon Sep 17 00:00:00 2001 From: gruenich <[email protected]> Date: Thu, 4 Dec 2014 17:19:53 +0100 Subject: [PATCH] FindLATEX: Use FPHSA to report status in standard way Otherwise LaTeX was marked as not found in the summary. --- Modules/FindLATEX.cmake | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/Modules/FindLATEX.cmake b/Modules/FindLATEX.cmake index e353d38..61f02fd 100644 --- a/Modules/FindLATEX.cmake +++ b/Modules/FindLATEX.cmake @@ -18,7 +18,7 @@ # LATEX2HTML_CONVERTER: path to the LaTeX2Html converter #============================================================================= -# Copyright 2002-2009 Kitware, Inc. +# Copyright 2002-2014 Kitware, Inc. # # Distributed under the OSI-approved BSD License (the "License"); # see accompanying file Copyright.txt for details. @@ -131,3 +131,9 @@ mark_as_advanced( PS2PDF_CONVERTER LATEX2HTML_CONVERTER ) + +include(${CMAKE_CURRENT_LIST_DIR}/FindPackageHandleStandardArgs.cmake) +find_package_handle_standard_args(Latex + REQUIRED_VARS LATEX_COMPILER PDFLATEX_COMPILER BIBTEX_COMPILER + MAKEINDEX_COMPILER DVIPS_CONVERTER PS2PDF_CONVERTER LATEX2HTML_CONVERTER +)
-- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
