On 12/9/2014 6:02 AM, Gregor Jasny wrote:
> +XCTEST_HOST
> +-----------
> +
> +XCTest works by injecting an XCTest CFBundle directly into an AppBundle
> +or Framework. This property names this destination target under test.
Please add mention of :prop_tgt:`XCTEST` here.
> \ No newline at end of file
Please end all sources with a newline.
> - if (target.GetPropertyAsBool("BUNDLE"))
> + if (target.IsCFBundleOnApple())
Please factor this refactoring hunk (and others like it, if any)
into a preceding commit with a message explaining the individual
part of the change.
> + cmSystemTools::Error("target has XCTEST property "
> + "but no XCTEST_HOST one.");
[snip]
> + cmSystemTools::Error("Cannot find XCTEST_HOST target: ", testHostName);
[snip]
> + cmSystemTools::Error("XCTEST_HOST target is not a Framework "
> + "or App Bundle: ", testHostName);
These should use IssueMessage too, please. Use the signature
that takes an explicit backtrace and pass target.GetBacktrace()
to provide some context.
Thanks,
-Brad
--
Powered by www.kitware.com
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Kitware offers various services to support the CMake community. For more
information on each offering, please visit:
CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers
