On 01/16/2015 08:42 AM, Brad King wrote:
> Go ahead and merge to 'next' for testing and follow up with any
> dashboard trouble. I'll still be able to review it there.
AFAICT the change to GNUInstallDirs is just to help projects use
the new feature, and not actually part of the new feature itself.
The feature itself just happens to use the same set of <dir> values.
It feels a bit strange to have CPACK_ variables set by GNUInstallDirs,
and to require CPACK_PACKAGING_INSTALL_PREFIX to be set before that
module is included.
Perhaps instead CPackRPM can provide an option to compute a default
for CPACK_PACKAGING_INSTALL_FULL_<dir> based on the GNUInstallDirs
values. This way GNUInstallDirs does not have to change at all,
and users can choose to include GNUInstallDirs and still set their
own CPACK_PACKAGING_INSTALL_FULL_<dir> values separately.
> + set(TMP_RPM_PREFIXES ${TMP_RPM_PREFIXES} PARENT_SCOPE)
Typically I quote the second argument in this case. It is not
strictly necessary but looks cleaner IMO.
Please look at adding test cases, perhaps in Tests/RunCMake,
to check the warning message about non-relocatable paths.
Thanks,
-Brad
--
Powered by www.kitware.com
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Kitware offers various services to support the CMake community. For more
information on each offering, please visit:
CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers
