On Mon, Feb 02, 2015 at 23:47:15 +0100, Roman Wüger wrote:
> I think the change is also required for the following line (line 424):
>
>
>
> if(!default_config && !configurationTypes.empty())
>
>
>
> Because here the ?default_config? could also be a valid pointer with an
> empty content/string.
>
> Nevertheless I had already posted a working patch which uses a std::vector
> and std::string instead to prevent such pointer problems.
Yeah, your patch is better. I'll revert mine and put yours up. Do you
have/want access to the stage to push it yourself? I can do so if not.
http://www.cmake.org/Wiki/CMake/Git/Develop
Thanks,
--Ben
P.S. Also, seems I hadn't switched this repo over to my Kitware email
anyways for this commit.
--
Powered by www.kitware.com
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Kitware offers various services to support the CMake community. For more
information on each offering, please visit:
CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers
