Fair points, I will make the changes. What is the recommended practice for updating patches on mailing lists? With pull requests it's easy because it picks up my changes I push to my branch automatically. I think if I push another patch to the mailing list it will start another email thread, which may cause lost context since this email chain won't be connected to the new one (not sure if that matters).
Thanks Brad. On Mon, Feb 16, 2015 at 10:35 AM, Brad King <brad.k...@kitware.com> wrote: > On 02/15/2015 03:27 PM, rcdailey.li...@gmail.com wrote: >> From: Robert Dailey <rcdai...@gmail.com> >> >> The -T parameter to CMake may now be specified through QtDialog >> (cmake-gui) via a new text field in the first-time configure >> wizard (below the generator chooser). > > Thanks for working on this. I think QCMake::setBinaryDirectory > also needs to check for CMAKE_GENERATOR_TOOLSET from an existing > cache file much like it already does for CMAKE_GENERATOR. One > may currently use the "Add Entry" button to pre-define an entry > for CMAKE_GENERATOR_TOOLSET to set this from the GUI indirectly. > > Since not all generators support this field, we should not present > it when a non-supporting generator is selected. This will need > some type of query on the selected generator to be added. > > Thanks, > -Brad > -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
