On 02/15/2015 03:52 PM, Gregor Jasny wrote:
> this series contains the latest XCTest patches.

Thanks.  The primary remaining work is to figure out how to get
these tests activated.  IIRC in earlier discussion you said that
some local machine setup is required.  For that we need some kind
of option/condition in Tests/CMakeLists.txt to activate these tests.
See existing options like "CMake_TEST_FindJsonCpp" for similar
examples of tests that require explicit local configuration on
the test machine.

Please also add a "Help/release/dev/xcode-xctest.rst" file with
release notes describing the features added by this patch series.
See other files in that directory for examples.

For the ${_CMAKE_OSX_SYSROOT_PATH}/../../Library/Frameworks path,
please look at using get_filename_component to strip components
instead of using "../" components in the path.

In Tests/XcodePlatformFrameworks for detecting the Xcode version
you can use XCODE_VERSION:

 http://www.cmake.org/cmake/help/v3.2/variable/XCODE_VERSION.html

Also this test could move to Tests/RunCMake/XcodeProject.  In
Tests/RunCMake/CMakeLists.txt one could pass XCODE_VERSION into
the test's RunCMakeTest.

Thanks,
-Brad

-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Reply via email to