Le 26/02/15 21:32, Brad King a écrit :
On 02/26/2015 03:23 PM, Raffi Enficiaud wrote:
We never specified explicitly which name to use. I think it
should be Matlab_ROOT_DIR because that makes sense whether the
user specified it or not.
Right, so I made the changes and updated the documentation. A kind
person tested my module and proposed to change the behaviour in order to
be able to change the Matlab_ROOT_DIR after the first configuration The
workflow would be:
- I start without Matlab_ROOT_DIR,
- Matlab_ROOT_DIR is automatically determined,
- I change Matlab_ROOT_DIR
I am expecting all dependent variables (cached or not) be updated to
reflect this change. Apparently this is something that is done in eg.
wxWidget.
The question is: should also this be implemented? The way I am seeing
this is to clear all variables when another Matlab_ROOT_DIR than the
cached/internal one is set.
We shouldn't have to disable the test. It can still be an
error for the MAIN_PROGRAM component to not be requested.
You can separate the name of the cache variable used as
the "one" search for "matlab" from the name of the result
variable used to provide the MAIN_PROGRAM component. That
will be consistent with the view that finding "matlab" is
an implementation detail on some platforms even when the
MAIN_PROGRAM component is not requested.
Please revise this patch further for the above.
Will do. Another question: may the test be dependent on a particular
site? For instance, on one of the builders, I have several versions of
Matlab. Is testing against the current build site something that would
be acceptable?
Best,
Raffi
--
Powered by www.kitware.com
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Kitware offers various services to support the CMake community. For more
information on each offering, please visit:
CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers
