On 03/14/2015 03:03 PM, Gregor Jasny wrote:
> I changed it into a Find module and it looks much more polished
> now.
Great.
> I fully agree that modifying the testee is not something one would
> expect when adding a test for it. Therefore I reverted the rpath
> setting for Frameworks and replaced it with a DYLD environment
> variable when calling xctest. For the App Bundle I reverted your
> ENABLE_EXPORTS call and replaced it with Xcode specific settings
> for the XCODE generator and a linker flag for the Makefile generator.
Okay.
> + target_link_libraries(${target}
> + PRIVATE "-bundle_loader $<TARGET_FILE:${testee}>")
Please try using this in a CMake source/build tree each with spaces
in the path. Quoting may need updating; perhaps:
target_link_libraries(${target}
PRIVATE -bundle_loader $<TARGET_FILE:${testee}>)
> Once you ACK the series I will create a topic branch and follow
> the developer instructions.
Please proceed.
Thanks,
-Brad
--
Powered by www.kitware.com
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Kitware offers various services to support the CMake community. For more
information on each offering, please visit:
CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers
