> I get conflicts applying on commit ff7ecb92. Please resolve. I rebased on ff7ecb92 to create the new attached patch. Here are the test results: https://open.cdash.org/buildSummary.php?buildid=3763362.
>> target_compile_options(${TARGET_NAME} PUBLIC
>> ":optionsFile=\"${ABS_PATH}/rel/path/filename\"")
>
>The COMPILE_OPTIONS are supposed to be given flags exactly as you'd like the
>tools to receive them, and CMake is supposed to take care of the quoting.
>This is different than the older COMPILE_FLAGS value that is just a command
>line string.
>
>Therefore I think you should be writing:
>
> target_compile_options(${TARGET_NAME} PUBLIC
> ":optionsFile=${ABS_PATH}/rel/path/filename")
>
>which is expected to work even if there is a space in the ABS_PATH value.
That seems to be working, but I need to do more testing.
Now that the flags seem to be working correctly, I'll need to remove the hard
coded "--link_once_templates" flag.
Geoffrey Viola
SOFTWARE ENGINEER
asirobots.com
-----Original Message-----
From: Brad King [mailto:brad.k...@kitware.com]
Sent: Wednesday, April 08, 2015 7:22 AM
To: Geoffrey Viola
Cc: cmake-developers@cmake.org
Subject: Re: FW: FW: [cmake-developers] Initial Attempt at Green Hill MULTI IDE
Generator Support
On 04/08/2015 01:20 AM, Geoffrey Viola wrote:
> Attached is a patch based off of the previous commit.
I get conflicts applying on commit ff7ecb92. Please resolve.
> target_compile_options(${TARGET_NAME} PUBLIC
> ":optionsFile=\"${ABS_PATH}/rel/path/filename\"")
The COMPILE_OPTIONS are supposed to be given flags exactly as you'd like the
tools to receive them, and CMake is supposed to take care of the quoting. This
is different than the older COMPILE_FLAGS value that is just a command line
string.
Therefore I think you should be writing:
target_compile_options(${TARGET_NAME} PUBLIC
":optionsFile=${ABS_PATH}/rel/path/filename")
which is expected to work even if there is a space in the ABS_PATH value.
-Brad
This message contains confidential information and is intended only for the
recipient. If you are not the named addressee you should not disseminate,
distribute or copy this e-mail. Please notify the sender immediately if you
have received this e-mail by mistake and delete this e-mail from your system.
Finally, the recipient should check this email and any attachments for the
presence of viruses. The company accepts no liability for any damage caused by
any virus transmitted by this email.
0001-ghs-gen-uses-cmake-vars-for-flags.patch
Description: 0001-ghs-gen-uses-cmake-vars-for-flags.patch
-- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
