Hi,

New version of patch attached.
I added a check on java tool to execute test only if java and shared library 
built by test have same architecture (32 or 64bit).

Marc




On 05/08/15 17:49, "Brad King" <[email protected]> wrote:

>On 08/05/2015 03:15 AM, CHEVRIER, Marc wrote:
>> For point 2., The best approach is to install 32 and 64bit
>> versions of Java SDK (Windows versions, not some cygwin or
>> MSYS versions) and ensure JAVA_HOME is NOT set in the
>> environment nor referenced in the PATH. In this case, CMake
>> FindJava.cmake module will look at the registry to retrieve
>> the correct java version.
>
>CMake's test suite needs to adapt to the environment in which
>it is run and not run this test unless the architecture of
>java and the toolchain match.  Certainly we can set up an
>environment in which it works but we should not fail just
>because that hasn't been done.
>
>On 08/05/2015 06:24 AM, CHEVRIER, Marc wrote:
>> Again, a new version for patch 4.
>
>Thanks.  I'd prefer not to enable CXX as a language in the
>project() command such that it affects the other Java tests.
>Please create a separate source tree for the new test.  Sorry
>I didn't notice this earlier.
>
>Meanwhile the other three patches now tested cleanly.
>
>Thanks,
>-Brad

Attachment: 0004-Add-support-for-javah-tool.patch
Description: 0004-Add-support-for-javah-tool.patch

-- 

Powered by www.kitware.com

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Kitware offers various services to support the CMake community. For more 
information on each offering, please visit:

CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers

Reply via email to