Hi there, I'm maintaining a CTest output parser for Bamboo. It was reported to me that CMake 3.3.1 produced parsing issues in my plugin. After digging into CMake source code, it seems that a bug was introduced with the replacement of direct use of cmXMLSafe and std::ostream in favor of cmXMLwriter.
cmXMLWriter is, I assume wrongly, output Safe content without (quotes,
etc.) escaping.
This simple modification corrects this to have pre-3.3 area behavior :
index c38c0de..7b71bae 100644
--- a/Source/cmXMLWriter.h
+++ b/Source/cmXMLWriter.h
@@ -94,12 +94,12 @@ private:
static cmXMLSafe SafeContent(const char* value)
{
- return cmXMLSafe(value).Quotes(false);
+ return cmXMLSafe(value);
}
static cmXMLSafe SafeContent(std::string const& value)
{
- return cmXMLSafe(value).Quotes(false);
+ return cmXMLSafe(value);
}
template <typename T>
Regards,
--
nǝıɥʇɐƜ
0001-escape-quotes.patch
Description: Binary data
-- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
