On 08/31/2015 06:25 PM, Raphael Kubo da Costa wrote:
> Commit 899458ab ("Tests: Cover NO_SONAME property for SHARED libraries")
> introduced a few new ExportImport tests, and the
> check_lib_{no}soname.cmake scripts that parse readelf(1)'s output.
>
> Make the regular expression matching the SONAME line output by readelf
> less strict, as the output format varies across implementations
Thanks! The changes look good, but perhaps more are needed.
The same regex appears in
Tests/Plugin/check_mod_soname.cmake
and has for years. I think that one should be updated too, but I
wonder why this problem has not been revealed in that test before.
Thanks,
-Brad
--
Powered by www.kitware.com
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Kitware offers various services to support the CMake community. For more
information on each offering, please visit:
CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers
