On Wed, Sep 16, 2015 at 9:41 AM, Brad King <brad.k...@kitware.com> wrote:
> On 09/16/2015 11:39 AM, Brad King wrote: > > On 09/16/2015 10:00 AM, David Gobbi wrote: > >> this new patch only changes the search for the include dirs. > > > > Thanks. Rather than calling find_path twice, the first call could > > just use HINTS instead of PATHS. HINTS are meant for this use case: > > searching paths detected from the system in some manner. They are > > searched before the generic system and environment paths. Does that > > work for your use case? > > > > Also, why does the second call not use the same list of suffixes? > > Meanwhile I split out the OS X framework path fix: > > FindPythonLibs: Fix OS X framework include directory search path > http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=ea2db3bb > > Please check that it looks correct on its own. Thanks, looks fine. I've modified my patch so that it only calls find_path once. It uses HINTS to search for the includes in the same prefix as where the library was found, which is probably the best place to start. I've left the framework dirs in PATHS because we don't necessarily want them to have priority, we just want to have them in the search path. - David
0001-FindPythonLibs-Match-include-dir-to-library-version.patch
Description: Binary data
-- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
