I wrote the documentation, added a genex test that checks it the given path is converted as expected on different platforms, and added another ExternalProject test for Windows that invokes pushd, which is is command sensitive to the path style. I wasn't sure about the VERSION I am supposed to write into the cmake_minimum_required() line in Tests/ExternalProjectShellPathGenex/CMakeLists.txt, so I chose 3.3.20150923. Maybe you need to adjust the version there? I tried to be as consistent as possible regarding the tests and their already existing fellow tests.
-----Original Message----- From: Brad King [mailto:brad.k...@kitware.com] Sent: Donnerstag, 17. September 2015 15:56 To: Kislinskiy, Stefan Cc: CHEVRIER, Marc; cmake-developers@cmake.org; James Johnston Subject: Re: [cmake-developers] generator expression for path slash conversion On 09/17/2015 09:51 AM, Kislinskiy, Stefan wrote: > I wrote a SHELL_PATH genex which uses > cmOutputConverter->ConvertToOutputFormat(..., SHELL) for the conversion. > I decided to name the genex SHELL_PATH instead of TO_SHELL_PATH for > the sake of consistency to other genexes like LOWER_CASE. What do you think? LGTM. > I would write some documentation as well of course. Yes, please. Also please look at extending the test suite to cover it. See Tests/GeneratorExpression for genex unit test examples. If possible we should also have a case that uses it in practice in a way that fails on invocation of an actual native tool if the slashes are wrong. That will confirm not only that the genex does what we expect but that it also solves the problem we're trying to solve. Thanks, -Brad
shell_path_genex_v3.patch
Description: shell_path_genex_v3.patch
-- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
