On 10/05/2015 06:59 PM, Colin Tracey wrote: > I sent a similar patch as plain text in an email to the list last > Friday, but after observing the email traffic It looks like you > prefer attachments. I also added documentation to this one.
Inline patches are fine and slightly preferred for me personally because it is easier to quote hunks while commenting. I simply hadn't caught up with all list traffic yet. Anyway, the change looks good and I've applied it with minor tweaks: CPackNSIS: Add options to set the bitmap for NSIS installer left side https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=3758af12 Thanks, -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
