On 10/07/2015 10:15 AM, Daniele E. Domenichelli wrote: > Please review the "IncludeUrl" topic[1] that adds a new "IncludeUrl" > module. This module adds the include_url command that is useful to > download and include other CMake modules from a given url.
I wish you had come asking about this proposal to hold discussion before going through all the work to implement this. I do not think this is a good idea as proposed, at least for deployment with upstream CMake. > The main use case for such a module is for groups that have several > projects or CMake scripts, handled by different developers, that import > the same CMake module that is sometimes updated, and they want to keep > these files synchronized in all the projects. This is very hard to > achieve when the developers are many and don't care too much about the > build system. Instead of adding this file to each project, this module > allows to put it somewhere, and automatically download and include it > when required. This means the module is not versioned with the includers and could break them with an update. If EXPECTED_HASH is used then the includer must be modified whenever there is an update anyway. If EXPECTED_HASH is not used then you're running code downloaded over a network with no chance to check it. Instead the common files can come with some external package and found with find_package. Then at least some versioning can be done. See KDE's extra-cmake-modules for example. -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
