On 11/30/2015 01:18 PM, Levi Morrison wrote: > My latest patch is attached. All tests seem to be working for me on > the compiler versions I have access to. Can you check it for any > glaring errors?
Good. This hunk: > + if (NOT CMAKE_CXX_COMPILER_FORCED) > + if (NOT CMAKE_CXX_STANDARD_COMPUTED_DEFAULT) > + set(CMAKE_CXX_STANDARD_DEFAULT 98) > + else() > + set(CMAKE_CXX_STANDARD_DEFAULT ${CMAKE_CXX_STANDARD_COMPUTED_DEFAULT}) > + endif() > + endif() still needs to be revised to account for recent changes: Project: Guess default standard dialect if compiler was forced (#15852) https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=441dba80 If CMAKE_CXX_COMPILER_FORCED is set then we now fall back to a guess. Otherwise it is an error for CMAKE_CXX_STANDARD_COMPUTED_DEFAULT to not be set. Thanks, -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers