On 01/16/2016 12:10 PM, Ashley Whetter wrote: > In response to issue 0003986, I've implemented a FILTER subcommand to the > "list" > command that filters a list using a regular expression.
Nice work. The change looks good except I'd like to bikeshed the name of the option. This is the first list() API that will use a regular expression as an argument, so I think "REGEX" should appear in the name, e.g. "FILTER_REGEX". Also the name should clarify whether the filter result includes or excludes the matches. Perhaps list(FILTER_REGEX_INCLUDE <list> <regex>) ? Alternatively the name could still be "FILTER" and there could be named arguments to control the rest of the details. I have no preference but would welcome other opinions. Thanks, -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
