On 19/01/2016 16:50, Brad King wrote:
On 01/19/2016 11:39 AM, Roger Leigh wrote:
Merged into next from the staging branch "xalanc" for review and
testing. Includes a couple of unit tests to validate. Since it depends
on XercesC, I hope what I've done here for the imported and non-imported
target cases is OK.
Thanks. Please also add a Help/release/dev/FindXalanC.rst release note
that mentions the new module.
Done. I can add more detail if needed here.
I've updated one of our nightly testing machines to enable the new test
for this topic.
+find_package(XercesC 3.0.0 REQUIRED)
>
Please add a comment here justifying use of this particular version number.
Explain that/why it does not depend on the XalanC version requested.
I think this is an assumption leaking from my own usage of it. I've
removed the version here.
+# ``XalanC_LIBRARIES``
+# Xalan libraries to be linked; note ``XercesC_LIBRARIES`` is also
+# required
Our convention is to include dependencies in reported values automatically.
See FindPNG for its use of ZLIB, for example.
OK, I've updated this to match.
Thanks,
Roger
--
Powered by www.kitware.com
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Kitware offers various services to support the CMake community. For more
information on each offering, please visit:
CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers