On Fri, Jan 22, 2016 at 17:34:03 +0100, Nicolas Desprès wrote: > I have pushed a first draft of the patch here: > > https://github.com/nicolasdespres/CMake/commit/67a4faad47378c07c97a29dd229d6f9fa500763b > > I have tested with a small project and it looks good.
Looks like a good start to me as well. I added some comments on the commit. > I would like to add some regression tests but I don't know from where to > start. > > The principle would be to duplicate and modify existing tests so that > CMAKE_NINJA_OUTPUT_PATH_PREFIX is set to "sub/" and the build directory is > changed from _build to _build/sub. A dummy build.ninja file containing > "subninja sub/build.ninja" should be generated in _build/build.ninja and > ninja should be called from _build instead of _build/sub. > > It would be great if you could point me some existing tests that could > serve as a base to do the above. The RunCMake test infrastructure would probably be the best place to start. It could be modified to do some of this work. Thanks, --Ben -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
