Michael Scott wrote: >> Yes. Did you have a close look at the commits? I'm not really sure they >> are correct, and I wonder if you have any thoughts on the first one which >> discusses interface? > I went back and had a closer look at the major changes. I think on the > whole the cmMessenger class is good and a clear improvement over the > previous organisation, however I imagine in its current form it would be > perhaps a bit tricky extending it for other environments (e.g. > displaying messages as GUI modal notifications), which I understood to > be one of the overall aims of the branch (correct me if I've > misunderstood of course though).
The aim of the branch is only to extract the class. That allows the further work on it. When it is extracted, it can be refactored with a virtual interface as you describe, and as is described in the 'cmMessenger: Extract from cmake class' commit. Thanks, Steve. -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
