On 05/23/2016 06:48 AM, Martin Ankerl wrote: > Here is an updated patch Thanks!
> +#include <cmsys/Base64.h> This looks unnecessary. > + const std::string cmdFile = hasher.HashString(cmd.str()) + ".cmd"; > + > + // TODO fail if can't open file > + std::ofstream fout(cmdFile); Please use cmGeneratedFileStream. Also please place the script files in the CMakeFiles/ directory. See cmake::GetCMakeFilesDirectoryPostSlash callers for examples. > - this->BuildCommandLine(cmdLines), this->ConstructComment(ccg), > + this->BuildCommandLine(cmdLines, false), this->ConstructComment(ccg), Please also update the call sites for PRE_BUILD, PRE_LINK, and POST_BUILD custom commands. Thanks, -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
