Folks, I believe I found a bug in FindProtobuf.cmake. Using set with two parameters will insert an unwanted semicolon, the list separator. The changes I made are like this (several occurrences):
- set(_protobuf_include_path -I ${CMAKE_CURRENT_SOURCE_DIR})
+ set(_protobuf_include_path "-I${CMAKE_CURRENT_SOURCE_DIR}")
I also added a test for FindProtobuf.cmake, which is a new addition. The
complete patch is attached. What I cannot figure out is how to run the test?
When I configure cmake build, I don't see an option to set the path to
protobuf. The test doesn't show up in `ctest -N` result.
Cheers,
Miro
0001-Removing-semicolon-in-FindProtobuf.cmake-and-adding-.patch
Description: 0001-Removing-semicolon-in-FindProtobuf.cmake-and-adding-.patch
-- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
