On 08/13/2016 08:18 PM, Dāvis Mosāns wrote: > Source/ProcessOutput.hxx.in | 160 > +++++++++++++++++++++++++++++++++++++ [snip] > + static const UINT defaultCodepage = @KWSYS_ENCODING_DEFAULT_CODEPAGE@;
Thanks. Overall the approach looks good now. I'd like to avoid having to configure this header just for the default codepage value. Also I'd like to avoid having to include `windows.h` publicly. Please move the implementation into a .cxx file to hide these parts away from includers. Thanks, -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
