----- On Dec 12, 2016, at 9:51 AM, Harry Mallon ha...@codexdigital.com wrote:
> Hello, > > I am messing around with the CPackProductbuild stuff to try to port over what > we > had before. Currently it support undocumented options > "CPACK_PREFLIGHT_SCRIPT", "CPACK_POSTFLIGHT_SCRIPT", > "CPACK_PREFLIGHT_<component>_SCRIPT" and > "CPACK_POSTFLIGHT_<component>_SCRIPT". > It looks like these are also supported (also undocumented) in > CPackPackageMaker. Are these options good names? Do they need to be these for > ease of porting from Package Maker? Productbuild inherited those variables by factoring out common pkg support between PackageMaker and ProductBuild. I'm not aware of porting concerns, but I can imagine that being useful. I think there *are* people using the undocumented variables with PackageMaker. > Should they start with CPACK_PRODUCTBUILD_* > as they are not generic? The other CPack generators have their own variable names for this kind of thing. And they also have separate code to handle it. In this case, we have 2 pkg based generators with a potential of using the same named variables. With PackageMaker being deprecated, CPACK_PRODUCTBUILD_* sounds good. Clint > > If the current names are fine I can prepare a pull req with documentation. > > Yours, > Harry > > Harry Mallon > CODEX | Software Engineer > 60 Poland Street | London | England | W1F 7NT > E ha...@codexdigital.com | T +44 203 7000 989 > -- > > Powered by www.kitware.com > > Please keep messages on-topic and check the CMake FAQ at: > http://www.cmake.org/Wiki/CMake_FAQ > > Kitware offers various services to support the CMake community. For more > information on each offering, please visit: > > CMake Support: http://cmake.org/cmake/help/support.html > CMake Consulting: http://cmake.org/cmake/help/consulting.html > CMake Training Courses: http://cmake.org/cmake/help/training.html > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Follow this link to subscribe/unsubscribe: > http://public.kitware.com/mailman/listinfo/cmake-developers -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
