On 04/28/2017 05:43 PM, Christoph Grüninger wrote: > I attached two patches implementing it.
Good start. Please reverse the order of the commits to convert to the nested conditions first. That will make the logic change in the second commit easier to follow. Also please update the test suite. Some existing tests may need updates (though I haven't checked). Also we should add a test for this use case in `Tests/RunCMake/find_package/RunCMakeTest.cmake`. The RunCMake infrastructure allows us to check CMake's output. One can add a test that searches for a DoesNotExist package to verify the error message. Please open a merge request for this as `CONTRIBUTING.rst` explains. Thanks, -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
