On 12/7/06, Axel Roebel <[EMAIL PROTECTED]> wrote:
On Wednesday 06 December 2006 17:36, Axel Roebel wrote:
> > I will test the module tomorrow.
> > Could you please put a RC2 of the `FindSWIG.cmake' on the bug tracker?
>
> That may take a day or too.
>
> I'll let you know.
There it is, called FindSWIG.cmake-2
It should take care of all your comments,
please have a look. I would especially be
interested to hear if it works on windows.
I can only try linux and Mac OS X
Cool!
The version works fine on Windows with 1.3.{29,30,31}!!!!
However I've got several comments
2. if the Swig executable version is changed, SWIG_DIR and
SWIG_VERSION are not updated. But as there are computed thanks to a
EXECUTE_PROCESS, if SWIG_EXECUTABLE changes, SWIG_DIR and SWIG_VERSION
must be updated.
2. I'm maybe paranoid, but I guess all internal variables declared by
a module should be prefixed by the module's name.
3. in the CMake/Modules/readme.txt, you can read:
"If the QUIET option is given to the command it will set the variable
XXX_FIND_QUIETLY to true before loading the FindXXX.cmake module."
but you use: FIND_SWIG_QUIETLY
4. Previous version only use SWIG_EXECUTABLE, there is no need to
introduce a new variable SWIG.
I put a third version of the bug tracker.
http://public.kitware.com/Bug/bug.php?op=show&bugid=4145
Thank you
--
Tristan Carel
Music with dinner is an insult both to the cook and the violinist.
_______________________________________________
CMake mailing list
[email protected]
http://www.cmake.org/mailman/listinfo/cmake
