On 10/19/07, Alex Neundorf wrote: > On Thursday 18 October 2007 21:25, Miguel A. Figueroa-Villanueva wrote: > > On 10/14/07, Alex Neundorf wrote: > > > On Saturday 13 October 2007 07:17, Miguel A. Figueroa-Villanueva wrote: > > > > Hello, > > > > > > > > I've been assigned the task of maintaining the ImageMagick find > > > > module. As such, I made a rewrite to support the complete toolchain > > > > (i.e., all command line executables) and would like to ask for user > > > > feedback before committing the changes. The new module is attached for > > > > reference. > > > > > > Why do you use FIND_PATH() instead of FIND_PROGRAM() ? > > > Then you wouldn't have to care for the different suffixes. > > > > Something like this should work: > > > > FIND_PROGRAM(ImageMagick_mogrify_EXECUTABLE mogrify ...) > > GET_FILENAME_COMPONENT(ImageMagick_EXECUTABLE_DIR > > ImageMagick_mogrify_EXECUTABLE PATH > > ) > > > > ... > > > > Then the only variable in the CACHE would be > > ImageMagick_mogrify_EXECUTABLE instead of ImageMagick_EXECUTABLE_DIR. > > > > Should I change ImageMagick_EXECUTABLE_DIR to ImageMagick_ROOT_DIR ?? > > Can you please post the new file before committing ?
I have posted the new file as feature request #5919 (http://www.cmake.org/Bug/view.php?id=5919). So, that the discussion can continue on the bug tracker with whoever is interested in this. Note that I'll commit after about a week if no one comments. I have taken care to replicate the VARIABLES and CACHE VARIABLES available when using the current module in the new module for backward compatibility. Alex, there is a note in it commenting why I reverted to thinking it is best to use FIND_PATH instead of FIND_PROGRAM. --Miguel _______________________________________________ CMake mailing list [email protected] http://www.cmake.org/mailman/listinfo/cmake
