On 02.04.08 19:30:21, Matthew Woehlke wrote: > Andreas Pakulat wrote: >> Ok, I give in. Do you mind separating the loop into two so its easier to >> see whats going on and we don't have two use-less cache variables? Then >> I'll apply what you send to kdevplatform and add a new version to the >> cmake bugreport. > > Done. I was resisting that because... well, you can look at the patch > (and see where I had to add redundant code) :-). Although this has the > elegance of not adding new variables. I decided to wrap the insides of > both FOREACH's in "IF(NOT Boost_INCLUDE_DIR)" in the theory that an > empty FOREACH is cheaper than the conditional string manipulation, and > that it's not worth having said IF twice to avoid an empty FOREACH. Of > course it would be easy to change this around. > > Anyway, patch attached.
Well, one could reduce the duplicated code with a macro (there's some more duplication in the file), but IMHO thats not worth it - especially the name-polution. Comitted to kdevplatform, updated script for the bugreport will be uploaded shortly. Andreas -- Your aim is high and to the right. _______________________________________________ CMake mailing list [email protected] http://www.cmake.org/mailman/listinfo/cmake
