Bill Hoffman wrote:

1. call these directly in check_type_size:
 check_include_file(sys/types.h HAVE_SYS_TYPES_H)
 check_include_file(stdint.h HAVE_STDINT_H)
 check_include_file(stddef.h HAVE_STDDEF_H)

2. Update the documentation for check_type_size to tell people that they need those checks.

3. Try to see if those have been called and issue a warning if they have not.


I am thinking 1 is the best solution and will avoid confusion. I don't think it will hurt because duplicate calls will be ignored (the test won't be done multiple times unless a different variable name is used, but in that case the check type size will not have worked anyway.


I went with 1 and did a commit.
$ cvs commit -m "ENH: make sure all required headers are checked before checking type size" CheckTypeSize.cmake
/cvsroot/CMake/CMake/Modules/CheckTypeSize.cmake,v  <--  CheckTypeSize.cmake
new revision: 1.31; previous revision: 1.30

-Bill

_______________________________________________
CMake mailing list
[email protected]
http://www.cmake.org/mailman/listinfo/cmake

Reply via email to