On Sat, Apr 11, 2009 at 1:36 PM, Daniel Nelson <[email protected]> wrote:
> When you call find_package(), variables can be set inside the find script for > arguments such as QUIET or REQUIRED. For FindFoo.cmake, these variables would > be Foo_FIND_QUIETLY and Foo_FIND_REQUIRED respectively. I think it's ugly and > confusing having some variable all in caps and others with a strange mixture > of CamelCase and caps. Further a strict reading of Modules/readme.txt > indicates that for a script FindFoo.cmake the variable set should be > Foo_FOUND. So it seems to me that the find script itself really should be > named in all caps, i.e. FindFOO.cmake. > > As things are now, most scripts are named FindFoo.cmake and most of them set > FOO_FOUND. I'd just like to plug my lint script for CMake files at this point. http://code.google.com/p/cmake-lint/ Among other things, it checks exactly the convention described above. Running it on cmake/Modules/*.* results in 7826 "bad practices", but they are my personal preferences so there will be false positives. A full description of the checks made are here: http://code.google.com/p/cmake-lint/wiki/CMakeStyleGuide regards, Richard _______________________________________________ Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://www.cmake.org/mailman/listinfo/cmake
