On Wednesday 14 April 2010, Gerald Hofmann wrote: > Hi *, > > attached please find a patch for #0009721. I would be happy if someone > feels to accept it. > > The version string output obviously is different to the NSIS dist binary > when built from Macports. > > > makensis -VERSION > > < v25-Feb-2010.cvs > > Version checking in cmCPackNSISGenerator.cxx fails indefinitely because the > expected regex is not matched. I have introduced an alternative version > string format checking for the Macports style version string. Both formats > are matched for NSIS version checking. > > I do not fully understand why the CPACK_TOPLEVEL_DIRECTORY access fails > when no matching NSIS version is found though. Maybe someone feels to fix > the error handling if actually no valid NSIS version string was returned.
Please put this in the bugtracker at http://public.kitware.com/Bug , so it doesn't get forgotten here on the list. Thanks for the patch Alex _______________________________________________ Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://www.cmake.org/mailman/listinfo/cmake
