Attached patches to the bug and on this email. ( http://public.kitware.com/Bug/**view.php?id=12284<http://public.kitware.com/Bug/view.php?id=12284> .)
I did not make it an option yet, as I'm not sure exactly how it should be done. However 0002-kwsys: This is just broken and should be fixed. Setting RecurseThroughSymlinks(false) would not even list the symlinks. Regarding (0001): I guess this is the one that should be optional? It is funny how directory symlinks are treated differently then normal symlinks. I would consider it simply a bug and fix it. 0003: Possibly make it an option? Again, I really can't think of a case when you would want the follow through symlink behaviour, but I might just be naive. On Thu, Jun 23, 2011 at 5:31 AM, Alan W. Irwin <ir...@beluga.phys.uvic.ca>wrote: > On 2011-06-22 12:04-0400 Bill Hoffman wrote: > > On 6/21/2011 4:43 PM, Alan W. Irwin wrote: >> >> So it is not a regression, but in my opinion it is still a bug. >>> >>> More comments at >>> http://public.kitware.com/Bug/**view.php?id=12284<http://public.kitware.com/Bug/view.php?id=12284> >>> . >>> >>> Please fix. >>> >>> >> Patches are welcome, please send one... It would have to be an option >> somehow at this point so as not to break existing code. >> > > I am fine with such an option. GNU tar (at least) also has an option > to follow symlinks or not. Of course, the CPack option will have > a different default than the GNU tar one, but that is required for > CPack backwards compatibility. > > I don't understand C++ or the C++ internals of CMake well enough to > put together a patch to solve this issue. So I am limited to helping > you guys out by doing testing to help clarify CMake bug issues and > commenting on the practical implications of certain CMake bug reports > like this one for the build systems of software projects like PLplot > and FreeEOS to give you a better idea of what is at stake. > > > Alan > __________________________ > Alan W. Irwin > > Astronomical research affiliation with Department of Physics and Astronomy, > University of Victoria (astrowww.phys.uvic.ca). > > Programming affiliations with the FreeEOS equation-of-state implementation > for stellar interiors (freeeos.sf.net); PLplot scientific plotting > software > package (plplot.org); the libLASi project (unifont.org/lasi); the Loads of > Linux Links project (loll.sf.net); and the Linux Brochure Project > (lbproject.sf.net). > __________________________ > > Linux-powered Science > __________________________ > ______________________________**_________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at http://www.kitware.com/** > opensource/opensource.html<http://www.kitware.com/opensource/opensource.html> > > Please keep messages on-topic and check the CMake FAQ at: > http://www.cmake.org/Wiki/**CMake_FAQ<http://www.cmake.org/Wiki/CMake_FAQ> > > Follow this link to subscribe/unsubscribe: > http://www.cmake.org/mailman/**listinfo/cmake<http://www.cmake.org/mailman/listinfo/cmake> >
0001-ArchiveWrite-Don-t-recurse-through-directory-symlink.patch
Description: Binary data
0002-kwsys-Glob-Fix-so-directory-symlinks-are-added-as-fi.patch
Description: Binary data
0003-cpack-Fix-12284-don-t-recurse-through-directory-syml.patch
Description: Binary data
_______________________________________________ Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://www.cmake.org/mailman/listinfo/cmake
