For debian packages (and others too?) It is odd to have the "-unspecified"
extension to package names for the nameless component.
It is common to have packages like:
myapp
myapp-dev
myapp-data
etc.
But the application component usually does not have an extension. (Sometimes -
bin is used but is not common). This patch makes ensures that the -unspecified
extension is not added to the package for the nameless component even though
the generated file name has it. AFAIK The previous argument for avoiding the -
unspecified name was that it would overwrite the generated monolithic package
file.
--
Cheers!
Kishore
>From 648977fbc8e0d22692f125fb4ed9fe6cc015b430 Mon Sep 17 00:00:00 2001
From: Kishore Jonnalagadda <[email protected]>
Date: Thu, 10 Nov 2011 20:18:06 +0530
Subject: [PATCH] Even through the file name has "Unpecified" in it, let the
control file and thus the installed package name not have
the -unspecified extension
---
Modules/CPackDeb.cmake | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/Modules/CPackDeb.cmake b/Modules/CPackDeb.cmake
index 26433bb..06076f7 100644
--- a/Modules/CPackDeb.cmake
+++ b/Modules/CPackDeb.cmake
@@ -321,7 +321,9 @@ IF(CPACK_DEB_PACKAGE_COMPONENT)
SET(CPACK_DEB_PACKAGE_COMPONENT_PART_NAME "-${CPACK_DEB_PACKAGE_COMPONENT}")
SET(CPACK_DEB_PACKAGE_COMPONENT_PART_PATH "/${CPACK_DEB_PACKAGE_COMPONENT}")
SET(WDIR "${CPACK_TOPLEVEL_DIRECTORY}/${CPACK_PACKAGE_FILE_NAME}/${CPACK_DEB_PACKAGE_COMPONENT}")
- STRING(TOLOWER "${CPACK_PACKAGE_NAME}${CPACK_DEB_PACKAGE_COMPONENT_PART_NAME}" CPACK_DEBIAN_PACKAGE_NAME)
+ IF(NOT CPACK_DEB_PACKAGE_COMPONENT STREQUAL "Unspecified")
+ STRING(TOLOWER "${CPACK_PACKAGE_NAME}${CPACK_DEB_PACKAGE_COMPONENT_PART_NAME}" CPACK_DEBIAN_PACKAGE_NAME)
+ ENDIF(NOT CPACK_DEB_PACKAGE_COMPONENT STREQUAL "Unspecified")
ELSE(CPACK_DEB_PACKAGE_COMPONENT)
SET(CPACK_DEB_PACKAGE_COMPONENT_PART_NAME "")
SET(CPACK_DEB_PACKAGE_COMPONENT_PART_PATH "")
--
1.7.5.4
--
Powered by www.kitware.com
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Follow this link to subscribe/unsubscribe:
http://www.cmake.org/mailman/listinfo/cmake
