I'm not a LZMA maintainer. I think FindLibLZMA is a good candidate to integrate CMake/Modules like FindBZip2 or FindZLib.
Mario On Wednesday, May 09, 2012 01:18:46 PM David Cole wrote: > Also, rather than adding yet-another-find-module to CMake, would it > instead be possible to add a LZMAConfig.cmake file to the LZMA > installation itself? > > (i.e. -- are you an LZMA maintainer, and could you put that file into > the LZMA install tree...? If so, you should prefer that route, because > it will work with existing CMake unchanged: as soon as you deploy that > file, others will benefit from it immediately.) > > On Wed, May 9, 2012 at 4:00 AM, Rolf Eike Beer <[email protected]> wrote: > >> Hi Eike, > >> > >> here a new version with the version support > > > > Looks good. Just a small nitpicks: > > > > -you should document also the LIBLZMA_VERSION_{MAJOR,MINOR,PATCH} > > variables > > > > -I would move setting LIBLZMA_LIBRARIES and LIBLZMA_INCLUDE_DIRS below the > > call to FPHSA and wrap it in an "if (LIBLZMA_FOUND)" > > > > Eike > > -- > > > > Powered by www.kitware.com > > > > Visit other Kitware open-source projects at > > http://www.kitware.com/opensource/opensource.html > > > > Please keep messages on-topic and check the CMake FAQ at: > > http://www.cmake.org/Wiki/CMake_FAQ > > > > Follow this link to subscribe/unsubscribe: > > http://www.cmake.org/mailman/listinfo/cmake > > -- > > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Please keep messages on-topic and check the CMake FAQ at: > http://www.cmake.org/Wiki/CMake_FAQ > > Follow this link to subscribe/unsubscribe: > http://www.cmake.org/mailman/listinfo/cmake -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://www.cmake.org/mailman/listinfo/cmake
